linux-kernel - Re: [PATCH v2 12/13] scsi: fnic: Add support for multiqueue (MQ) in fnic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202310300032.2awCqkfn-lkp@intel.com>
Date:   Mon, 30 Oct 2023 01:20:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Karan Tilak Kumar <kartilak@...co.com>, sebaddel@...co.com
Cc:     oe-kbuild-all@...ts.linux.dev, arulponn@...co.com,
        djhawar@...co.com, gcboffa@...co.com, mkai2@...co.com,
        satishkh@...co.com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Karan Tilak Kumar <kartilak@...co.com>
Subject: Re: [PATCH v2 12/13] scsi: fnic: Add support for multiqueue (MQ) in
 fnic driver

Hi Karan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to jejb-scsi/for-next linus/master v6.6-rc7 next-20231027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Karan-Tilak-Kumar/scsi-fnic-Modify-definitions-to-sync-with-VIC-firmware/20231028-060626
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20231027180302.418676-13-kartilak%40cisco.com
patch subject: [PATCH v2 12/13] scsi: fnic: Add support for multiqueue (MQ) in fnic driver
config: x86_64-randconfig-001-20231029 (https://download.01.org/0day-ci/archive/20231030/202310300032.2awCqkfn-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231030/202310300032.2awCqkfn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310300032.2awCqkfn-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/scsi/fnic/fnic_scsi.c: In function 'fnic_queuecommand':
>> drivers/scsi/fnic/fnic_scsi.c:606:6: warning: variable 'tag' set but not used [-Wunused-but-set-variable]
     int tag = 0;
         ^~~


vim +/tag +606 drivers/scsi/fnic/fnic_scsi.c

   601	
   602	int fnic_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc)
   603	{
   604		struct request *const rq = scsi_cmd_to_rq(sc);
   605		uint32_t mqtag = 0;
 > 606		int tag = 0;
   607		uint16_t hwq = 0;
   608	
   609		mqtag = blk_mq_unique_tag(rq);
   610		hwq = blk_mq_unique_tag_to_hwq(mqtag);
   611		tag = blk_mq_unique_tag_to_tag(mqtag);
   612	
   613		return fnic_queuecommand_int(sc, mqtag, hwq);
   614	}
   615	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki