linux-kernel - Re: [PATCH] KVM: x86: cleanup unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202310300228.s4py0SQf-lkp@intel.com>
Date:   Mon, 30 Oct 2023 02:41:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     José Pekkarinen <jose.pekkarinen@...hound.fi>,
        seanjc@...gle.com, pbonzini@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        skhan@...uxfoundation.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        José Pekkarinen <jose.pekkarinen@...hound.fi>,
        x86@...nel.org, hpa@...or.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] KVM: x86: cleanup unused variables

Hi José,

kernel test robot noticed the following build errors:

[auto build test ERROR on kvm/queue]
[also build test ERROR on linus/master v6.6-rc7 next-20231027]
[cannot apply to kvm/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jos-Pekkarinen/KVM-x86-cleanup-unused-variables/20231029-174855
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
patch link:    https://lore.kernel.org/r/20231029093859.138442-1-jose.pekkarinen%40foxhound.fi
patch subject: [PATCH] KVM: x86: cleanup unused variables
config: i386-buildonly-randconfig-006-20231030 (https://download.01.org/0day-ci/archive/20231030/202310300228.s4py0SQf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231030/202310300228.s4py0SQf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310300228.s4py0SQf-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/x86/kvm/emulate.c: In function 'decode_modrm':
>> arch/x86/kvm/emulate.c:950:9: error: 'rc' undeclared (first use in this function); did you mean 'rq'?
     950 |         rc = do_insn_fetch_bytes(_ctxt, sizeof(_type));                 \
         |         ^~
   arch/x86/kvm/emulate.c:1225:45: note: in expansion of macro 'insn_fetch'
    1225 |                                 modrm_ea += insn_fetch(u16, ctxt);
         |                                             ^~~~~~~~~~
   arch/x86/kvm/emulate.c:950:9: note: each undeclared identifier is reported only once for each function it appears in
     950 |         rc = do_insn_fetch_bytes(_ctxt, sizeof(_type));                 \
         |         ^~
   arch/x86/kvm/emulate.c:1225:45: note: in expansion of macro 'insn_fetch'
    1225 |                                 modrm_ea += insn_fetch(u16, ctxt);
         |                                             ^~~~~~~~~~
   arch/x86/kvm/emulate.c: In function 'decode_abs':
>> arch/x86/kvm/emulate.c:950:9: error: 'rc' undeclared (first use in this function); did you mean 'rq'?
     950 |         rc = do_insn_fetch_bytes(_ctxt, sizeof(_type));                 \
         |         ^~
   arch/x86/kvm/emulate.c:1317:35: note: in expansion of macro 'insn_fetch'
    1317 |                 op->addr.mem.ea = insn_fetch(u16, ctxt);
         |                                   ^~~~~~~~~~
   arch/x86/kvm/emulate.c: In function 'decode_imm':
>> arch/x86/kvm/emulate.c:950:9: error: 'rc' undeclared (first use in this function); did you mean 'rq'?
     950 |         rc = do_insn_fetch_bytes(_ctxt, sizeof(_type));                 \
         |         ^~
   arch/x86/kvm/emulate.c:4560:27: note: in expansion of macro 'insn_fetch'
    4560 |                 op->val = insn_fetch(s8, ctxt);
         |                           ^~~~~~~~~~


vim +950 arch/x86/kvm/emulate.c

6226686954c4cc drivers/kvm/x86_emulate.c Avi Kivity       2007-11-20  945  
67cbc90db5c0f0 arch/x86/kvm/emulate.c    Takuya Yoshikawa 2011-05-15  946  /* Fetch next part of the instruction being emulated. */
e85a10852c26d7 arch/x86/kvm/emulate.c    Takuya Yoshikawa 2011-07-30  947  #define insn_fetch(_type, _ctxt)					\
9506d57de3bc82 arch/x86/kvm/emulate.c    Paolo Bonzini    2014-05-06  948  ({	_type _x;							\
9506d57de3bc82 arch/x86/kvm/emulate.c    Paolo Bonzini    2014-05-06  949  									\
9506d57de3bc82 arch/x86/kvm/emulate.c    Paolo Bonzini    2014-05-06 @950  	rc = do_insn_fetch_bytes(_ctxt, sizeof(_type));			\
67cbc90db5c0f0 arch/x86/kvm/emulate.c    Takuya Yoshikawa 2011-05-15  951  	if (rc != X86EMUL_CONTINUE)					\
67cbc90db5c0f0 arch/x86/kvm/emulate.c    Takuya Yoshikawa 2011-05-15  952  		goto done;						\
9506d57de3bc82 arch/x86/kvm/emulate.c    Paolo Bonzini    2014-05-06  953  	ctxt->_eip += sizeof(_type);					\
8616abc2537933 arch/x86/kvm/emulate.c    Nick Desaulniers 2017-06-27  954  	memcpy(&_x, ctxt->fetch.ptr, sizeof(_type));			\
17052f16a51af6 arch/x86/kvm/emulate.c    Paolo Bonzini    2014-05-06  955  	ctxt->fetch.ptr += sizeof(_type);				\
9506d57de3bc82 arch/x86/kvm/emulate.c    Paolo Bonzini    2014-05-06  956  	_x;								\
67cbc90db5c0f0 arch/x86/kvm/emulate.c    Takuya Yoshikawa 2011-05-15  957  })
67cbc90db5c0f0 arch/x86/kvm/emulate.c    Takuya Yoshikawa 2011-05-15  958  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki