linux-kernel - Re: [PATCH] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f685552-4bbf-480a-b1d7-9573b554dcdc@linaro.org>
Date:   Sun, 29 Oct 2023 09:13:17 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     jrodrigues <jrodrigues@...met.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)

On 27/10/2023 21:15, jrodrigues wrote:
> 

1. Drop stray blank line
2. Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC (and consider --no-git-fallback argument). It
might happen, that command when run on an older kernel, gives you
outdated entries. Therefore please be sure you base your patches on
recent Linux kernel.

Your patch will be ignored since you did not send it to anyone :(


> TQMa7x (revision 01xxx) uses a different (LM75A) temperature sensor.
> The two sensors use different I2C address, so we can set both sensors
> simultaneously.
> 
> Signed-off-by: João Rodrigues <jrodrigues@...met.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> index fe42b0a468..b87560d037 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> @@ -128,7 +128,14 @@ vgen6_reg: vldo4 {
>  		};
>  	};
>  
> -	/* NXP SE97BTP with temperature sensor + eeprom */
> +	/* LM75A - temperature sensor, TQMa7x 01xx */
> +	lm75a: temperature-sensor@48 {
> +		compatible = "national,lm75a";
> +		reg = <0x48>;
> +		status = "okay";

Drop status.

> +	};
> +
> +	/* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
>  	se97b: temperature-sensor-eeprom@1e {
>  		compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>  		reg = <0x1e>;
> --
> 
> The differences in the ICs are shown here:
> The TQMa7 manual only references the latest version
> https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/embedded-modul/TQ-Socket/TQMa7x/TQMa7x.UM.0203.pdf
> in section 3.2.4, while the board manual
> https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/carrierboard/MBa7x/MBa7x.UM.0101.pdf
> in section 4.1.2 references the old version, introduced by this patch.
> 
> I have tested this change in a board which uses the TQMa7x
> module, and with this patch we always a temperature sensors available.

This does not look like patch at all... Patches are created the easiest
with b4 or git format-patch.

Best regards,
Krzysztof