linux-kernel - Re: [PATCH] checkpatch: allow tags between co-developed-by and their sign-off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0693460e-2104-49af-b1dc-5ffae0f279c5@kernel.org>
Date:   Sun, 29 Oct 2023 10:35:26 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Przemek Kitszel <przemyslaw.kitszel@...el.com>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        workflows@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        Jacob Keller <jacob.e.keller@...el.com>,
        Mateusz Polchlopek <mateusz.polchlopek@...el.com>
Subject: Re: [PATCH] checkpatch: allow tags between co-developed-by and their
 sign-off

On 24/10/2023 11:15, Przemek Kitszel wrote:
> On 10/23/23 16:02, Sean Christopherson wrote:
>> +Mateusz
>>
>> On Mon, Oct 23, 2023, Przemek Kitszel wrote:
>>> Additional tags between Co-developed-by and corresponding Signed-off-by
>>> could include Reviewed-by tags collected by Submitter, which is also
>>> a Co-developer, but should sign-off at the very end of tags provided by
>>> the Submitter.
>>
>> ...
>>
>>> Mateusz Polchlopek <mateusz.polchlopek@...el.com> has reported this to me.
>>
>> Heh, there's a tag for that...
>>
>>    Reported-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
>>
>> And it's usually a good idea to Cc the reporter in case there are questions they
>> can help answer.
> 
> Heh ;) then I would get a checkpatch warning for not providing Link: to
> the report, somehow I wanted to avoid those for checkpatch contrib :)

You wanted Suggested-by. There is no bug here, so Reported-by is not
suitable.

Best regards,
Krzysztof