[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <767f32a8-d00b-4bb9-bbea-f972caced064@gmail.com>
Date: Mon, 30 Oct 2023 12:39:48 -0700
From: Kui-Feng Lee <sinquersw@...il.com>
To: Yuran Pereira <yuran.pereira@...mail.com>, bpf@...r.kernel.org,
yonghong.song@...ux.dev
Cc: ast@...nel.org, brauner@...nel.org, daniel@...earbox.net,
haoluo@...gle.com, iii@...ux.ibm.com, john.fastabend@...il.com,
jolsa@...nel.org, kpsingh@...nel.org, kuifeng@...a.com,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
mykolal@...com, sdf@...gle.com, shuah@...nel.org, song@...nel.org,
linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: Add malloc failure checks
in bpf_iter
Acked-by: Kui-Feng Lee <thinker.li@...il.com>
On 10/27/23 22:24, Yuran Pereira wrote:
> Since some malloc calls in bpf_iter may at times fail,
> this patch adds the appropriate fail checks, and ensures that
> any previously allocated resource is appropriately destroyed
> before returning the function.
>
> Signed-off-by: Yuran Pereira <yuran.pereira@...mail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> index 123a3502b8f0..1e02d1ba1c18 100644
> --- a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> +++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> @@ -698,7 +698,7 @@ static void test_overflow(bool test_e2big_overflow, bool ret1)
> goto free_link;
>
> buf = malloc(expected_read_len);
> - if (!buf)
> + if (!ASSERT_OK_PTR(buf, "malloc"))
> goto close_iter;
>
> /* do read */
> @@ -868,6 +868,8 @@ static void test_bpf_percpu_hash_map(void)
>
> skel->rodata->num_cpus = bpf_num_possible_cpus();
> val = malloc(8 * bpf_num_possible_cpus());
> + if (!ASSERT_OK_PTR(val, "malloc"))
> + goto out;
>
> err = bpf_iter_bpf_percpu_hash_map__load(skel);
> if (!ASSERT_OK_PTR(skel, "bpf_iter_bpf_percpu_hash_map__load"))
> @@ -1044,6 +1046,8 @@ static void test_bpf_percpu_array_map(void)
>
> skel->rodata->num_cpus = bpf_num_possible_cpus();
> val = malloc(8 * bpf_num_possible_cpus());
> + if (!ASSERT_OK_PTR(val, "malloc"))
> + goto out;
>
> err = bpf_iter_bpf_percpu_array_map__load(skel);
> if (!ASSERT_OK_PTR(skel, "bpf_iter_bpf_percpu_array_map__load"))
Powered by blists - more mailing lists