linux-kernel - Re: [PATCH] [RFC] Add missing NULL check in `tls_strp_check_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231030150512.254220a5@kernel.org>
Date:   Mon, 30 Oct 2023 15:05:12 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Frederik Deweerdt <deweerdt.lkml@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] Add missing NULL check in
 `tls_strp_check_queue_ok`

On Mon, 30 Oct 2023 14:57:29 -0700 Frederik Deweerdt wrote:
> We see `tls_strp_check_queue_ok` running into a NULL deref when
> evaluating `TCP_SKB_CB(skb)->seq`.
> 
> This commit attempts to address the issue by exiting the loop if
> skb->next is NULL, and has proven stable under load.
> 
> That said i don't understand the code enough to convince myself that
> the NULL check is indeed required, and i would be happy gather data if
> that's useful.

Hm. Can you share the decoded stack trace?