linux-kernel - Re: [PATCH] fs/gfs2: Fix slab-use-after-free in gfs2_qd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU41DktH6+Hxsv3kYSiXenjoLJ58P6+mO9Yjhex5M0=aVA@mail.gmail.com>
Date:   Mon, 30 Oct 2023 23:38:24 +0100
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Juntong Deng <juntong.deng@...look.com>
Cc:     rpeterso@...hat.com, gfs2@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        syzbot+29c47e9e51895928698c@...kaller.appspotmail.com
Subject: Re: [PATCH] fs/gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

Hello Juntong,

On Sun, Oct 29, 2023 at 10:11 PM Juntong Deng <juntong.deng@...look.com> wrote:
> In gfs2_put_super(), whether withdrawn or not, the quota should
> be cleaned up by gfs2_quota_cleanup() and wait for all quota to
> be deallocated.
>
> Otherwise struct gfs2_sbd has been freed before gfs2_qd_dealloc
> (rcu callback) is completed, resulting in use-after-free.
>
> Also, gfs2_destroy_threads() and gfs2_quota_cleanup() have
> already been called in gfs2_make_fs_ro(), so there is no need to
> call them again subsequently, whether withdrawn or not.
>
> Reported-by: syzbot+29c47e9e51895928698c@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=29c47e9e51895928698c
> Signed-off-by: Juntong Deng <juntong.deng@...look.com>
> ---
>  fs/gfs2/super.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
> index a4b3655c5361..d21c04a22d73 100644
> --- a/fs/gfs2/super.c
> +++ b/fs/gfs2/super.c
> @@ -602,13 +602,15 @@ static void gfs2_put_super(struct super_block *sb)
>         }
>         spin_unlock(&sdp->sd_jindex_spin);
>
> -       if (!sb_rdonly(sb)) {
> +       if (!sb_rdonly(sb))
>                 gfs2_make_fs_ro(sdp);
> -       }
> -       if (gfs2_withdrawn(sdp)) {
> -               gfs2_destroy_threads(sdp);
> +       else {
> +               if (gfs2_withdrawn(sdp))
> +                       gfs2_destroy_threads(sdp);
> +
>                 gfs2_quota_cleanup(sdp);
>         }
> +
>         WARN_ON(gfs2_withdrawing(sdp));
>
>         /*  At this point, we're through modifying the disk  */
> --
> 2.39.2

thanks for this fix, I've merged it.

Andreas