linux-kernel - Re: [PATCH v2] kpageflags: respect folio head-page flag placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUA6qq6zXuc0fqOE@casper.infradead.org>
Date:   Mon, 30 Oct 2023 23:22:18 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Gregory Price <gourry.memverge@...il.com>
Cc:     linux-mm@...ck.org, akpm@...ux-foundation.org, david@...hat.com,
        vbabka@...e.cz, naoya.horiguchi@...ux.dev,
        linux-kernel@...r.kernel.org,
        Gregory Price <gregory.price@...verge.com>
Subject: Re: [PATCH v2] kpageflags: respect folio head-page flag placement

On Mon, Oct 30, 2023 at 02:00:05PM -0400, Gregory Price wrote:
> kpageflags reads page-flags directly from the page, even when the
> respective flag is only updated on the headpage of a folio.
> 
> Update bitchecks to use PAGEFLAG() interfaces to check folio for the
> referenced, dirty, lru, active, and unevictable bits.

But uptodate, writeback and reclaim (amongst others) are also defined
only on the head page.

>  	u |= kpf_copy_bit(k, KPF_UPTODATE,	PG_uptodate);
>  	u |= kpf_copy_bit(k, KPF_WRITEBACK,	PG_writeback);
>  
>  	u |= kpf_copy_bit(k, KPF_RECLAIM,	PG_reclaim);
>  
>  	if (PageSwapCache(page))
>  		u |= 1 << KPF_SWAPCACHE;
>  	u |= kpf_copy_bit(k, KPF_SWAPBACKED,	PG_swapbacked);
>  
>  	u |= kpf_copy_bit(k, KPF_MLOCKED,	PG_mlocked);