linux-kernel - Re: [PATCH V3][3/4] mmc: Add dw mobile mmc cmdq rtk driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76b68a17-9cd8-4a65-bc56-2170fc7fd363@linaro.org>
Date:   Mon, 30 Oct 2023 08:34:34 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jyan Chou [周芷安] <jyanchou@...ltek.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "jh80.chung@...sung.com" <jh80.chung@...sung.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>
Cc:     "riteshh@...eaurora.org" <riteshh@...eaurora.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        "doug@...morgal.com" <doug@...morgal.com>,
        "tonyhuang.sunplus@...il.com" <tonyhuang.sunplus@...il.com>,
        "abel.vesa@...aro.org" <abel.vesa@...aro.org>,
        "william.qiu@...rfivetech.com" <william.qiu@...rfivetech.com>
Subject: Re: [PATCH V3][3/4] mmc: Add dw mobile mmc cmdq rtk driver

On 30/10/2023 08:30, Jyan Chou [周芷安] wrote:
> Hi Krzysztof,
> 
>> Use Linux coding style. This driver looks like one for staging, not ready for submission. :/
> 
> We had modified our code to match Linux coding style.

Unfortunately, not much...

> 
>>> +     mcq_writel(host, AHB, 0);
>>> +     dev_info(dev, "AHB=0x%x, dw_mci_cqe_suspend ret=%d\n",
>>> +              mcq_readl(host, AHB), ret);
>> Drop useless success/function entry/exit messages..
> 
> We had drop useless function.
> 
>> Why? This is not an error. If it were, then it should be build stage error.
> 
> It was our mistake to use dev_err here, we had corrected it.

I have no clue what you are referring to. Respond inline as requested by
mailing list etiquette.

> 
>> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong.
> 
> We had removed MODULE_ALIAS().
> Please check our new post below, thanks.
> https://patchwork.kernel.org/project/linux-mmc/patch/20231030062749.2840-4-jyanchou@realtek.com/

Please rework the driver from scratch to look like Linux driver. It was
not looking at the beginning at all.


Best regards,
Krzysztof