linux-kernel - Re: [PATCH] firmware: ti_sci: Fix an off-by-one in ti_sci_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a85d4bd-7e90-4a1d-aa55-4d9070fdfc16@kadam.mountain>
Date:   Mon, 30 Oct 2023 11:02:48 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Tero Kristo <t-kristo@...com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] firmware: ti_sci: Fix an off-by-one in
 ti_sci_debugfs_create()

On Mon, Oct 30, 2023 at 11:00:59AM +0300, Dan Carpenter wrote:
> On Sun, Oct 29, 2023 at 08:52:36AM +0100, Christophe JAILLET wrote:
> > The ending NULL is not taken into account by strncat(), so switch to
> > strlcat() to correctly compute the size of the available memory when
> > building 'debug_name'.
> > 
> > Because of the difference in the return type between strncat() and
> > strlcat(), some code shuffling is needed.
> > 
> > Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> 
> The fixes tag isn't really required.

Ah sorry.  It's an off by one.  Yeah, that's a bug even if it doesn't
affect runtime.  I don't know why I didn't read this commit message
better...

regards,
dan carpenter