linux-kernel - Re: [RESEND PATCH] fs: Fix typo in access_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231030-debatten-nachrangig-f58abcdac530@brauner>
Date:   Mon, 30 Oct 2023 09:32:37 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     gaoyusong <a869920004@....com>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] fs: Fix typo in access_override_creds()

On Mon, Oct 30, 2023 at 01:52:35AM +0000, gaoyusong wrote:
> From: Yusong Gao <a869920004@....com>
> 
> Fix typo in access_override_creds(), modify non-RCY to non-RCU.
> 
> Signed-off-by: gaoyusong <a869920004@....com>
> ---
>  fs/open.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/open.c b/fs/open.c
> index 98f6601fbac6..72eb20a8256a 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -442,7 +442,7 @@ static const struct cred *access_override_creds(void)
>  	 * 'get_current_cred()' function), that will clear the
>  	 * non_rcu field, because now that other user may be
>  	 * expecting RCU freeing. But normal thread-synchronous
> -	 * cred accesses will keep things non-RCY.
> +	 * cred accesses will keep things non-RCU.

I think this might have been intended as a joke aka "non-RCY" as in
"non-racy" here. I think best would be to change it to something like
"cred accesses will keep things non-racy and allows to avoid rcu freeing"
if you care enough.