linux-kernel - Re: Question about LTS 4.19 patch "89047634f5ce NFS: Don't interrupt file writeout due to fatal errors"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023103023-playmaker-jingle-9d15@gregkh>
Date:   Mon, 30 Oct 2023 10:19:03 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     ChenXiaoSong <chenxiaosongemail@...mail.com>
Cc:     trond.myklebust@...merspace.com, chenxiaosong@...inos.cn,
        Anna.Schumaker@...app.com, sashal@...nel.org,
        liuzhengyuan@...inos.cn, huangjinhui@...inos.cn,
        liuyun01@...inos.cn, huhai@...inos.cn, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: Question about LTS 4.19 patch "89047634f5ce NFS: Don't interrupt
 file writeout due to fatal errors"

On Mon, Oct 30, 2023 at 05:04:35PM +0800, ChenXiaoSong wrote:
> 
> On 2023/10/30 16:58, Greg KH wrote:
> > If you just revert that one patch, is the issue resolved?  And what
> > about other stable releases that have that change in it?
> > 
> > If this does need to be reverted, please submit a patch that does so and
> > we can review it that way.
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> In my opinion, this patch is not for fixing a bug, but is part of a
> refactoring patchset. The 'Fixes:' tag should not be added.

Nothing we can do about that now, right?  And to try to ask developers
about a change they made in 2019 is a bit rough, don't you think?  If
you think the change is incorrect, please submit a patch to resolve it
after you have tested that it works properly.

thanks,

greg k-h