linux-kernel - Re: [PATCH v2] firmware: ti_sci: Fix an off-by-one in ti_sci_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd8ab7d2-d59b-4973-9180-0389b29fad0e@kadam.mountain>
Date:   Mon, 30 Oct 2023 14:06:38 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Tero Kristo <t-kristo@...com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] firmware: ti_sci: Fix an off-by-one in
 ti_sci_debugfs_create()

On Mon, Oct 30, 2023 at 11:12:26AM +0100, Christophe JAILLET wrote:
> The ending NULL is not taken into account by strncat(), so switch to
> snprintf() to correctly build 'debug_name'.
> 
> Using snprintf() also makes the code more readable.
> 
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> v2:
>    - use snprintf() to simplify code   [Dan Carpenter]
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter