linux-kernel - Re: [PATCH v5 2/6] staging: octeon: remove typedef in enum cvmx_helper_interface_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023103003-federal-harvest-c1ae@gregkh>
Date:   Mon, 30 Oct 2023 12:36:25 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Oliver Crumrine <ozlinux@...mail.com>, colin.i.king@...il.com,
        sumitraartsy@...il.com, u.kleine-koenig@...gutronix.de,
        geert@...ux-m68k.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v5 2/6] staging: octeon: remove typedef in enum
 cvmx_helper_interface_mode_t

On Mon, Oct 30, 2023 at 02:02:34PM +0300, Dan Carpenter wrote:
> On Mon, Oct 30, 2023 at 07:24:37AM +0100, Greg KH wrote:
> > On Sun, Oct 29, 2023 at 10:17:21AM -0700, Guenter Roeck wrote:
> > > On Mon, Aug 28, 2023 at 11:39:07AM -0400, Oliver Crumrine wrote:
> > > > Remove typedef in enum cvmx_helper_interface_mode_t, and rename all instances
> > > > to cvmx_helper_interface_mode
> > > > 
> > > > Signed-off-by: Oliver Crumrine <ozlinux@...mail.com>
> > > 
> > > In linux-next:
> > > 
> > > Building mips:cavium_octeon_defconfig ... failed
> > > --------------
> > > Error log:
> > > drivers/staging/octeon/ethernet.c: In function 'cvm_oct_common_get_stats':
> > > drivers/staging/octeon/ethernet.c:204:37: error: storage size of 'rx_status' isn't known
> > >   204 |         struct cvmx_pip_port_status rx_status;
> > >       |                                     ^~~~~~~~~
> > > drivers/staging/octeon/ethernet.c:205:37: error: storage size of 'tx_status' isn't known
> > >   205 |         struct cvmx_pko_port_status tx_status;
> > >       |                                     ^~~~~~~~~
> > > drivers/staging/octeon/ethernet.c:205:37: warning: unused variable 'tx_status' [-Wunused-variable]
> > > drivers/staging/octeon/ethernet.c:204:37: warning: unused variable 'rx_status' [-Wunused-variable]
> > >   204 |         struct cvmx_pip_port_status rx_status;
> > >       |                                     ^~~~~~~~~
> > > drivers/staging/octeon/ethernet.c: In function 'cvm_oct_probe':
> > > drivers/staging/octeon/ethernet.c:801:22: error: variable 'imode' has initializer but incomplete type
> > >   801 |                 enum cvmx_helper_interface_mode imode =
> > >       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > drivers/staging/octeon/ethernet.c:801:49: error: storage size of 'imode' isn't known
> > >   801 |                 enum cvmx_helper_interface_mode imode =
> > >       |                                                 ^~~~~
> > > drivers/staging/octeon/ethernet.c:801:49: warning: unused variable 'imode' [-Wunused-variable]
> > > 
> > > Bisect points to this patch. Bisect log attached.
> > > 
> > > As usual, my apologies for the noise if this has already been reported
> > > and/or fixed.
> > 
> > It has not been reported, thanks for it, I'll go revert the offending
> > commits.  And I need to figure out how to build this driver better, I
> > get no build-failures from anyone for it when stuff like this happens,
> > odd...
> 
> We did report it.
> 
> https://lore.kernel.org/all/CA+G9fYvVETLEtiZ=MFRrxgXpmgirVHz-tDOxhU=7_9dtmx7o5g@mail.gmail.com/

Ick, missed that, sorry.

> It only fails for Octeon def_configs.  Just cross compiling on ARM
> isn't enough.  All the stub code is just for compile testing and doesn't
> work...

Ah, that makes more sense.  Sorry for missing this previously.

greg k-h