linux-kernel - [PATCH v2 1/2] Staging: rts5208: Replace strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231030115939.48985-1-nicymimz@gmail.com>
Date:   Mon, 30 Oct 2023 14:59:34 +0300
From:   Nancy Nyambura <nicymimz@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     nicydaniels@...il.com, outreachy@...ts.linux.dev,
        Nancy Nyambura <nicymimz@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: [PATCH v2 1/2] Staging: rts5208: Replace strncpy() with strscpy()

warning found by checkpatch.pl script.I replaced the usage of strncpy()
with strscpy() in the code(line 524) for the buf buffer to improve
string copying.This is appropriate since strscpy() is used when you want
to copy a NUL-terminated string and the destination buffer requires
trailing NUL-padding.

Signed-off-by: Nancy Nyambura <nicymimz@...il.com>
---
Changes in v2:
  - Make the commit message more clearer.
 
drivers/staging/rts5208/rtsx_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
index 08bd768ad34d..52324b8ebbc7 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
+++ b/drivers/staging/rts5208/rtsx_scsi.c
@@ -523,7 +523,7 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 
 	if (sendbytes > 8) {
 		memcpy(buf, inquiry_buf, 8);
-		strncpy(buf + 8, inquiry_string, sendbytes - 8);
+		strscpy(buf + 8, inquiry_string, sendbytes - 8);
 		if (pro_formatter_flag) {
 			/* Additional Length */
 			buf[4] = 0x33;
-- 
2.40.1