linux-kernel - Re: [PATCH net] net: page_pool: add missing free_percpu when page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZT+cb4sO3PK1EbT5@nanopsycho>
Date:   Mon, 30 Oct 2023 13:07:11 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jijie Shao <shaojijie@...wei.com>
Cc:     hawk@...nel.org, ilias.apalodimas@...aro.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        jdamato@...tly.com, shenjian15@...wei.com, wangjie125@...wei.com,
        liuyonglong@...wei.com, linyunsheng@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: page_pool: add missing free_percpu when
 page_pool_init fail

Mon, Oct 30, 2023 at 10:12:56AM CET, shaojijie@...wei.com wrote:
>From: Jian Shen <shenjian15@...wei.com>
>
>When ptr_ring_init() returns failure in page_pool_init(), free_percpu()
>is not called to free pool->recycle_stats, which may cause memory
>leak.

Would be nice to see the use of imperative mood in the patch description
too, not only patch subject. Nevertheless, fix looks fine:

Reviewed-by: Jiri Pirko <jiri@...dia.com>