linux-kernel - Re: [PATCH net-next v2 9/9] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8672933b-0840-47bd-8211-93fa56c03116@microchip.com>
Date:   Mon, 30 Oct 2023 12:41:48 +0000
From:   <Parthiban.Veerasooran@...rochip.com>
To:     <robh@...nel.org>
CC:     <Thorsten.Kummermehr@...rochip.com>, <casper.casan@...il.com>,
        <devicetree@...r.kernel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <kuba@...nel.org>, <UNGLinuxDriver@...rochip.com>,
        <linux-doc@...r.kernel.org>, <horms@...nel.org>,
        <pabeni@...hat.com>, <andrew@...n.ch>, <rdunlap@...radead.org>,
        <Horatiu.Vultur@...rochip.com>, <Nicolas.Ferre@...rochip.com>,
        <robh+dt@...nel.org>, <linux-kernel@...r.kernel.org>,
        <conor+dt@...nel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <Woojung.Huh@...rochip.com>,
        <netdev@...r.kernel.org>, <Steen.Hegelund@...rochip.com>,
        <corbet@....net>
Subject: Re: [PATCH net-next v2 9/9] dt-bindings: net: add Microchip's LAN865X
 10BASE-T1S MACPHY

Hi,

On 23/10/23 11:10 pm, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, 23 Oct 2023 21:16:49 +0530, Parthiban Veerasooran wrote:
>> Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1
>> combines a Media Access Controller (MAC) and an Ethernet PHY to enable
>> 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module
>> implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE
>> 802.3 standard and a 10BASE-T1S physical layer transceiver integrated
>> into the LAN8650/1. The communication between the Host and the MAC-PHY is
>> specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6).
>>
>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>
>> ---
>>   .../bindings/net/microchip,lan865x.yaml       | 101 ++++++++++++++++++
>>   MAINTAINERS                                   |   1 +
>>   2 files changed, 102 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: [error] syntax error: mapping values are not allowed here (syntax)
> 
> dtschema/dtc warnings/errors:
> make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/microchip,lan865x.example.dts'
> Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: mapping values are not allowed in this context
> make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/net/microchip,lan865x.example.dts] Error 1
> ./Documentation/devicetree/bindings/net/microchip,lan865x.yaml:21:53: mapping values are not allowed in this context
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan865x.yaml: ignoring, error parsing file
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231023154649.45931-10-Parthiban.Veerasooran@microchip.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
Sorry, somehow I missed doing this check. Will fix this in the next 
revision.

Best Regards,
Parthiban V
> 
>