[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6xstp2bsrdrrcosddk7jcwdvcojek2b7njqqjw2cggl5f7xpuo@etrfki4orlwy>
Date: Mon, 30 Oct 2023 16:55:35 +0100
From: Daniel Wagner <dwagner@...e.de>
To: Keith Busch <kbusch@...nel.org>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
Christoph Hellwig <hch@....de>,
Niklas Cassel <Niklas.Cassel@....com>,
Kenji Tomonaga <tkenbo@...il.com>
Subject: Re: [PATCH v2] nvme: update firmware version after commit
On Fri, Oct 13, 2023 at 10:43:48AM -0600, Keith Busch wrote:
> On Fri, Oct 13, 2023 at 06:34:20PM +0200, Daniel Wagner wrote:
> > if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, NVME_CSI_NVM,
> > - log, sizeof(*log), 0))
> > + log, sizeof(*log), 0)) {
> > dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
> > + goto out_free_log;
> > + }
> > +
> > + afi = le64_to_cpu(log->afi);
> > + if (afi & 0x30) {
>
> That should be 'afi & 0x70'.
I've update the patch accordingly and send Kenij and one of our customer
to test it.
Powered by blists - more mailing lists