[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ca19ca8-d3c6-4789-a9d8-4f1637bfa71e@amd.com>
Date: Mon, 30 Oct 2023 13:39:15 -0400
From: Aurabindo Pillai <aurabindo.pillai@....com>
To: José Pekkarinen <jose.pekkarinen@...hound.fi>,
harry.wentland@....com, sunpeng.li@....com,
Rodrigo.Siqueira@....com, skhan@...uxfoundation.org
Cc: alexander.deucher@....com, christian.koenig@....com,
Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
dillon.varone@....com, Jun.Lei@....com, george.shen@....com,
samson.tam@....com, SyedSaaem.Rizvi@....com,
stable@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] drm/amd/display: remove redundant check
On 2023-10-30 13:17, José Pekkarinen wrote:
> This patch addresses the following warning spotted by
> using coccinelle where the case checked does the same
> than the else case.
>
> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
>
> Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32")
>
> Cc: stable@...r.kernel.org
> Signed-off-by: José Pekkarinen <jose.pekkarinen@...hound.fi>
> ---
> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index ecea008f19d3..d940dfa5ae43 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
> } else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
> *MinPrefetchMode = 0;
> *MaxPrefetchMode = 0;
> - } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> - dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> - *MinPrefetchMode = 0;
> - *MaxPrefetchMode = 3;
> } else {
> *MinPrefetchMode = 0;
> *MaxPrefetchMode = 3;
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@....com>
Powered by blists - more mailing lists