[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <169869215960.2773399.671365445660310243.b4-ty@kernel.org>
Date: Mon, 30 Oct 2023 11:59:05 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: linux-perf-users@...r.kernel.org, atrajeev@...ux.vnet.ibm.com,
tianruidong@...ux.alibaba.com, coresight@...ts.linaro.org,
suzuki.poulose@....com, James Clark <james.clark@....com>
Cc: Ian Rogers <irogers@...gle.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Mark Rutland <mark.rutland@....com>,
Jiri Olsa <jolsa@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Anushree Mathur <anushree.mathur@...ux.vnet.ibm.com>,
linux-kernel@...r.kernel.org,
Adrian Hunter <adrian.hunter@...el.com>,
Tiezhu Yang <yangtiezhu@...ngson.cn>,
Kajol Jain <kjain@...ux.ibm.com>
Subject: Re: [PATCH] perf tests: test_arm_coresight: Simplify source iteration
On Mon, 23 Oct 2023 14:15:49 +0100, James Clark wrote:
> There are two reasons to do this, firstly there is a shellcheck warning
> in cs_etm_dev_name(), which can be completely deleted. And secondly the
> current iteration method doesn't support systems with both ETE and ETM
> because it picks one or the other. There isn't a known system with this
> configuration, but it could happen in the future.
>
> Iterating over all the sources for each CPU can be done by going through
> /sys/bus/event_source/devices/cs_etm/cpu* and following the symlink back
> to the Coresight device in /sys/bus/coresight/devices. This will work
> whether the device is ETE, ETM or any future name, and is much simpler
> and doesn't require any hard coded version numbers
>
> [...]
Applied to perf-tools-next, thanks!
Powered by blists - more mailing lists