[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47cf6dd2-dcfa-468b-9bcb-3af32f6d9c4b@linaro.org>
Date: Tue, 31 Oct 2023 18:12:01 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Md Sadre Alam <quic_mdalam@...cinc.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
conor+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
broonie@...nel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mtd@...ts.infradead.org, linux-spi@...r.kernel.org,
quic_srichara@...cinc.com, qpic_varada@...cinc.com
Subject: Re: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support
On 31/10/2023 13:03, Md Sadre Alam wrote:
> Signed-off-by: Md Sadre Alam <quic_mdalam@...cinc.com>
> Signed-off-by: Sricharan R <quic_srichara@...cinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 5f83ee42a719..b44acb1fac74 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -336,6 +336,11 @@ sdhc_1: mmc@...4000 {
> status = "disabled";
> };
>
> + bch: qpic_ecc {
> + compatible = "qcom,ipq9574-ecc";
NAK. There are so many wrong things with it... Let's start with missing
checkpatch. Then with unndeeded label. Then with not allowed underscores
in node names.
Finally:
> + status = "ok";
Drop.
Best regards,
Krzysztof
Powered by blists - more mailing lists