[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d5dace72-093d-4bed-b02b-ed05401b34aa@wanadoo.fr>
Date: Tue, 31 Oct 2023 18:19:50 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: dimadrumspro@...oo.com, dimadrumspro@...il.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: comedi: drivers: ssv_dnp: fixed a brace coding
style issue
Le 31/10/2023 à 17:25, dimadrumspro@...oo.com a écrit :
> From: dimaaac <dimadrumspro@...il.com>
>
> Fixed a coding style issue, as well as a typo (lowercased word)
> and removed unnecessary filename comment.
>
> Signed-off-by: dimaaac <dimadrumspro@...il.com>
> ---
> drivers/comedi/drivers/ssv_dnp.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/comedi/drivers/ssv_dnp.c b/drivers/comedi/drivers/ssv_dnp.c
> index 813bd0853b0b..d0747767810b 100644
> --- a/drivers/comedi/drivers/ssv_dnp.c
> +++ b/drivers/comedi/drivers/ssv_dnp.c
> @@ -1,7 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
> - * ssv_dnp.c
> - * generic comedi driver for SSV Embedded Systems' DIL/Net-PCs
> + * Generic comedi driver for SSV Embedded Systems' DIL/Net-PCs
> * Copyright (C) 2001 Robert Schwebel <robert@...webel.de>
> *
> * COMEDI - Linux Control and Measurement Device Interface
> @@ -91,13 +90,13 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
> if (ret)
> return ret;
>
> - if (chan < 8) { /* Port A */
> + if (chan < 8) /* Port A */
> mask = 1 << chan;
> outb(PAMR, CSCIR);
> - } else if (chan < 16) { /* Port B */
> + else if (chan < 16) /* Port B */
> mask = 1 << (chan - 8);
> outb(PBMR, CSCIR);
> - } else { /* Port C */
> + else /* Port C */
Hi,
did you compile your change?
I don't think that it compiles. The {} looks needed here.
CJ
> /*
> * We have to pay attention with port C.
> * This is the meaning of PCMR:
> @@ -109,7 +108,6 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
> */
> mask = 1 << ((chan - 16) * 2);
> outb(PCMR, CSCIR);
> - }
>
> val = inb(CSCDR);
> if (data[0] == COMEDI_OUTPUT)
Powered by blists - more mailing lists