linux-kernel - Re: [PATCH] kbuild: Add inline-account tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASstN=r7ZjEu5p8Au0Au8RqCNgDL8_fCzK1JknTaW=bFw@mail.gmail.com>
Date:   Wed, 1 Nov 2023 02:40:43 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kbuild: Add inline-account tool

On Mon, Oct 23, 2023 at 8:23 AM Andi Kleen <ak@...ux.intel.com> wrote:
>
> > How to use this tool?
> >
> > I did not get any output?
>
> Hmm, perhaps you need CONFIG_DEBUG_INFO=y ?

Please print a hint suggesting CONFIG_DEBUG_INFO
if "objdump --source" does not output the
source-mixed disassembly.

>
> > I do not think this patch is mature enough
> > regarding the coding style.
> >
> > Please polish the code.
>
> Don't follow. It's standard python code style, and the
> other python scripts in scripts/ use the same.

I hoped somebody would have provided some code reviews,
but it looks like it did not get people's interest.

See other scripts and check how the code is structured in functions.

I do not want to see a patch like
94a03e1d22e8dc75ddec159b2efadd4c6354503a

So, the script should be written in good quality
from day 1.

Also, PEP-8 is worth reading to learn good coding style
if you have not checked.

--
Best Regards
Masahiro Yamada