linux-kernel - Re: [PATCH RFC 1/2] dt-bindings: arm: Document reboot mode magic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e8502221-30f7-4f92-9143-0e1a2a66b86b@quicinc.com>
Date:   Tue, 31 Oct 2023 14:25:29 -0700
From:   Elliot Berman <quic_eberman@...cinc.com>
To:     Rob Herring <robh@...nel.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>,
        Melody Olvera <quic_molvera@...cinc.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>
Subject: Re: [PATCH RFC 1/2] dt-bindings: arm: Document reboot mode magic



On 10/31/2023 10:48 AM, Rob Herring wrote:
> On Mon, Oct 30, 2023 at 02:31:33PM -0700, Elliot Berman wrote:
>> Add bindings to describe vendor-specific reboot modes. Values here
>> correspond to valid parameters to vendor-specific reset types in PSCI
>> SYSTEM_RESET2 call.
>>
>> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
>> ---
>>  Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml
>> index 0c5381e081bd..dc23e901bd0a 100644
>> --- a/Documentation/devicetree/bindings/arm/psci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/psci.yaml
>> @@ -122,6 +122,19 @@ patternProperties:
>>        [3] Documentation/devicetree/bindings/power/power-domain.yaml
>>        [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml
>>  
>> +  "^reboot-mode-.*$":
>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>> +    minItems: 1
>> +    maxItems: 2
>> +    description: |
>> +      Describes a vendor-specific reset type. The string after "reboot-mode-"
>> +      maps a reboot mode to the parameters in the PSCI SYSTEM_RESET2 call.
>> +
>> +      Parameters are named reboot-mode-xxx = <type[, cookie]>, where xxx
>> +      is the name of the magic reboot mode, type is the lower 31 bits
>> +      of the reset_type, and, optionally, the cookie value. If the cookie
>> +      is not provided, it is defaulted to zero.
> 
> Please use and possibly extend the existing reboot-mode binding.
> 

Sure, I can do that. I noticed most of the reboot-mode devices not doing that, but they probably should.

I've sent patches to fix that:

https://lore.kernel.org/all/20231031-ref-reboot-mode-v1-1-18dde4faf7e8@quicinc.com/
https://lore.kernel.org/all/20231031-ref-nvmem-reboot-mode-v1-1-c1af9070ce52@quicinc.com/

>> +
>>  required:
>>    - compatible
>>    - method
>>
>> -- 
>> 2.41.0
>>