[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b9407b5d-3dba-3e7d-139b-075728b8346c@collabora.com>
Date: Tue, 31 Oct 2023 08:49:47 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Zheng Wang <zyytlz.wz@....com>
Cc: Kyrie.Wu@...iatek.com, bin.liu@...iatek.com, mchehab@...nel.org,
matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, Irui.Wang@...iatek.com,
security@...nel.org, hackerzheng666@...il.com,
1395428693sheep@...il.com, alex000young@...il.com,
amergnat@...libre.com, wenst@...omium.org
Subject: Re: [PATCH 0/2] media: mtk-jpeg: Remove cancel worker in
mtk_jpeg_remove to avoid the crash of multi-core JPEG devices
On 10/27/23 12:16, Zheng Wang wrote:
> This patch reverts commit c677d7ae8314
> ("media: mtk-jpeg: Fix use after free bug due to uncanceled work").
> The job_timeout_work is initialized only for
> the single-core JPEG device so it will cause the crash for multi-core
> JPEG devices.
>
> Fix it by removing the cancel_delayed_work_sync function.
>
> Fixes: c677d7ae8314 ("media: mtk-jpeg: Fix use after free bug due to uncanceled work")
> Signed-off-by: Zheng Wang <zyytlz.wz@....com>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> ---
> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> index 7194f88edc0f..60425c99a2b8 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> @@ -1403,7 +1403,6 @@ static void mtk_jpeg_remove(struct platform_device *pdev)
> {
> struct mtk_jpeg_dev *jpeg = platform_get_drvdata(pdev);
>
> - cancel_delayed_work_sync(&jpeg->job_timeout_work);
> pm_runtime_disable(&pdev->dev);
> video_unregister_device(jpeg->vdev);
> v4l2_m2m_release(jpeg->m2m_dev);
Please send all three patches as a single series and version it with v2.
Add cover letter with changelog.
# git format-patch --cover-letter -v2 -3
--
Best regards,
Dmitry
Powered by blists - more mailing lists