linux-kernel - Re: [PATCH v8 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2023 06:39:45 +0000
From:   Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "maarten.lankhorst@...ux.intel.com" 
        <maarten.lankhorst@...ux.intel.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "airlied@...il.com" <airlied@...il.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v8 03/16] dt-bindings: media: mediatek: mdp3: add config
 for MT8195 RDMA

On Mon, 2023-10-30 at 14:26 -0500, Rob Herring wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote:
> > Added the configuration for MT8195 RDMA. In comparison to MT8183,
> it
> > no longer shares SRAM with RSZ, and there are now preconfigured 5
> mbox.
> > 
> > Signed-off-by: Moudy Ho <moudy.ho@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> > ---
> >  .../bindings/media/mediatek,mdp3-rdma.yaml    | 26
> ++++++++++++++++++-
> >  1 file changed, 25 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > index c043204cf210..504334a76fb3 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > @@ -22,6 +22,7 @@ properties:
> >    compatible:
> >      enum:
> >        - mediatek,mt8183-mdp3-rdma
> > +      - mediatek,mt8195-mdp3-rdma
> >        - mediatek,mt8195-vdo1-rdma
> >  
> >    reg:
> > @@ -58,7 +59,7 @@ properties:
> >  
> >    mboxes:
> >      minItems: 1
> > -    maxItems: 2
> > +    maxItems: 5
> >  
> >    interrupts:
> >      maxItems: 1
> > @@ -98,6 +99,29 @@ allOf:
> >          - mboxes
> >          - mediatek,gce-events
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: mediatek,mt8195-mdp3-rdma
> > +
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: RDMA clock
> > +
> > +        mboxes:
> > +          items:
> > +            - description: used for 1st data pipe from RDMA
> > +            - description: used for 2nd data pipe from RDMA
> > +            - description: used for 3rd data pipe from RDMA
> > +            - description: used for 4th data pipe from RDMA
> > +            - description: used for the data pipe from SPLIT
> 
> Following the prior comments, add these entries to the top-level 
> 'mboxes' and then here just put 'minItems: 5'.
> 
> Rob

Hi Rob,

Thanks for assisting with the review and suggesting an improved method
in patch [2/16] and here for bounding related item quantites.

I have a question regarding the current item description. It seems to
imply a specific order. If the order of the description is different
for any reason, should it be fully re-listed under 'allOf'?

Sincerely,
Moudy