linux-kernel - Re: [PATCH v4 2/2] riscv: Optimize bitops with Zbb extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2023 07:52:50 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Charlie Jenkins <charlie@...osinc.com>
CC:     "Wang, Xiao W" <xiao.w.wang@...el.com>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "ardb@...nel.org" <ardb@...nel.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "Li, Haicheng" <haicheng.li@...el.com>,
        "ajones@...tanamicro.com" <ajones@...tanamicro.com>,
        "Liu, Yujie" <yujie.liu@...el.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] riscv: Optimize bitops with Zbb extension


> > > > +static __always_inline unsigned long variable__ffs(unsigned long word)
> > > > +{
> > > > +	int num;
> > > > +
> > > > +	asm_volatile_goto(
> > > > +		ALTERNATIVE("j %l[legacy]", "nop", 0, RISCV_ISA_EXT_ZBB, 1)
> > > > +		: : : : legacy);
> > > > +
> > > 
> > > On this and following asm blocks, checkpatch outputs:  "Lines should not
> > > end with a '('".
> > 
> > I did below check, but I got no warning.
> > # ./scripts/checkpatch.pl v4-0002-riscv-Optimize-bitops-with-Zbb-extension.patch
> > total: 0 errors, 0 warnings, 280 lines checked
> > May I know how you do the check?
> > BTW, I see arch/riscv/include/asm/jump_label.h and arch/riscv/include/asm/cpufeature.h have similar code.
> 
> I normally use the --strict flag since that is what the Patchwork server
> uses.

FWIW, checkpatch output does require human interpretation. It is only a
"dumb" perl script, and particularly for asm stuff the complaints can
often be ignored. IMO, this is one of those times.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)