linux-kernel - Re: [PATCH] tracing/kprobes: Fix the order of argument descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98413d47-986f-bf94-0793-865a5a4dc80d@quicinc.com>
Date:   Tue, 31 Oct 2023 15:18:14 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Yujie Liu <yujie.liu@...el.com>,
        <linux-trace-kernel@...r.kernel.org>
CC:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Tom Zanussi <zanussi@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/kprobes: Fix the order of argument descriptions



On 10/31/2023 9:43 AM, Yujie Liu wrote:
> The order of descriptions should be consistent with the argument list of
> the function, so "kretprobe" should be the second one.
> 
> int __kprobe_event_gen_cmd_start(struct dynevent_cmd *cmd, bool kretprobe,
>                                   const char *name, const char *loc, ...)
> 
> Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
> Suggested-by: Mukesh Ojha <quic_mojha@...cinc.com>
> Signed-off-by: Yujie Liu <yujie.liu@...el.com>

Thanks.

Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh

> ---
>   kernel/trace/trace_kprobe.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index e834f149695b..47812aa16bb5 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1020,9 +1020,9 @@ EXPORT_SYMBOL_GPL(kprobe_event_cmd_init);
>   /**
>    * __kprobe_event_gen_cmd_start - Generate a kprobe event command from arg list
>    * @cmd: A pointer to the dynevent_cmd struct representing the new event
> + * @kretprobe: Is this a return probe?
>    * @name: The name of the kprobe event
>    * @loc: The location of the kprobe event
> - * @kretprobe: Is this a return probe?
>    * @...: Variable number of arg (pairs), one pair for each field
>    *
>    * NOTE: Users normally won't want to call this function directly, but