| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231031020159.587686-1-suhui@nfschina.com>
Date: Tue, 31 Oct 2023 10:02:00 +0800
From: Su Hui <suhui@...china.com>
To: mturquette@...libre.com, sboyd@...nel.org
Cc: Su Hui <suhui@...china.com>, mike.looijmans@...ic.nl,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [PATCH] clk: si5341: fix an error code problem in si5341_output_clk_set_rate
regmap_bulk_write() return zero or negative error code, return 'err'
rather than '0'.
Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver")
Signed-off-by: Su Hui <suhui@...china.com>
---
drivers/clk/clk-si5341.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
index 9599857842c7..9b1cc5a83b5b 100644
--- a/drivers/clk/clk-si5341.c
+++ b/drivers/clk/clk-si5341.c
@@ -898,7 +898,7 @@ static int si5341_output_clk_set_rate(struct clk_hw *hw, unsigned long rate,
err = regmap_bulk_write(output->data->regmap,
SI5341_OUT_R_REG(output), r, 3);
- return 0;
+ return err;
}
static int si5341_output_reparent(struct clk_si5341_output *output, u8 index)
--
2.30.2
Powered by blists - more mailing lists