linux-kernel - Re: [PATCH] mfd: intel-lpss: Add check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZUDYOa0hrc5qif4k@smile.fi.intel.com>
Date:   Tue, 31 Oct 2023 12:34:33 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Chen Ni <nichen@...as.ac.cn>
Cc:     lee@...nel.org, mika.westerberg@...ux.intel.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Add check for platform_get_irq

On Tue, Oct 31, 2023 at 06:36:42AM +0000, Chen Ni wrote:
> The platform_get_irq() might be failed and return a negative result.
> So there should have an error handling code.

NAK.

Have you checked the implementation of intel_lpcc_probe()?

> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")

It does not fix anything, except maybe an error code.
Also it misses PCI counterpart.

...

That said, I would expect that in intel_lpss_probe() the unset / erroneous IRQ
(which actually shouldn't be checked against 0 at all) should be returned as is.


i.e.

	if (!info || !info->mem || info->irq <= 0)
		return -EINVAL;

be converted to

	if (!info || !info->mem)
		return -EINVAL;

	if (info->irq < 0)
		return info->irq;

That kind of patch I will accept.

-- 
With Best Regards,
Andy Shevchenko