linux-kernel - Re: [PATCH v3] ti: fix possible memory leak in _ti_omap4_clkctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUDZ_tDvM7oUBfkq@smile.fi.intel.com>
Date:   Tue, 31 Oct 2023 12:42:06 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Hangyu Hua <hbh25y@...il.com>
Cc:     kristo@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        tony@...mide.com, claudiu.beznea@...rochip.com, robh@...nel.org,
        dario.binacchi@...rulasolutions.com, linux-omap@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ti: fix possible memory leak in
 _ti_omap4_clkctrl_setup()

On Tue, Oct 31, 2023 at 06:30:10PM +0800, Hangyu Hua wrote:
> kstrndup() and kstrdup_and_replace() in clkctrl_get_name() can perform
> dynamic memory allocation. So clkctrl_name needs to be freed when
> provider->clkdm_name is NULL.

> Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> ---
> 
> 	 v2 and v3: fix commit info.

I believe I gave you my Rb tag. It's your responsibility to care it on if you
send a new version. Otherwise, please tell what makes you think that tag should
not be here?

-- 
With Best Regards,
Andy Shevchenko