[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231031125928.235685-3-yajun.deng@linux.dev>
Date: Tue, 31 Oct 2023 20:59:27 +0800
From: Yajun Deng <yajun.deng@...ux.dev>
To: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
vincent.guittot@...aro.org, dietmar.eggemann@....com,
rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
bristot@...hat.com, vschneid@...hat.com
Cc: linux-kernel@...r.kernel.org, Yajun Deng <yajun.deng@...ux.dev>
Subject: [PATCH v3 2/3] sched: Don't trace stat runtime for task group
The rt entity can be a task group. We will trace stat runtime for each
task, so we don't need to trace stat runtime for task group.
Move trace_sched_stat_runtime in update_current_exec_runtime.
Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
---
v3: New patch.
---
kernel/sched/deadline.c | 2 --
kernel/sched/rt.c | 2 --
kernel/sched/sched.h | 1 +
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index a9f84428c4b5..70b5c5b47106 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1301,8 +1301,6 @@ static void update_curr_dl(struct rq *rq)
schedstat_set(curr->stats.exec_max,
max(curr->stats.exec_max, delta_exec));
- trace_sched_stat_runtime(curr, delta_exec, 0);
-
update_current_exec_runtime(curr, now, delta_exec, true);
if (dl_entity_is_special(dl_se))
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 79cf80d73822..1e155c7658ae 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1016,8 +1016,6 @@ static void update_curr_rt(struct rq *rq)
schedstat_set(curr->stats.exec_max,
max(curr->stats.exec_max, delta_exec));
- trace_sched_stat_runtime(curr, delta_exec, 0);
-
update_current_exec_runtime(curr, now, delta_exec,
rt_entity_is_task(rt_se));
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 6f0169d9b306..f7014e19bc0a 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -3268,6 +3268,7 @@ static inline void update_current_exec_runtime(struct task_struct *curr,
curr->se.exec_start = now;
if (task) {
+ trace_sched_stat_runtime(curr, delta_exec, curr->se.vruntime);
account_group_exec_runtime(curr, delta_exec);
cgroup_account_cputime(curr, delta_exec);
}
--
2.25.1
Powered by blists - more mailing lists