[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231031022017.1515471-3-guanjun@linux.alibaba.com>
Date: Tue, 31 Oct 2023 10:20:17 +0800
From: 'Guanjun' <guanjun@...ux.alibaba.com>
To: dave.jiang@...el.com, dmaengine@...r.kernel.org,
linux-kernel@...r.kernel.org, vkoul@...nel.org,
tony.luck@...el.com, fenghua.yu@...el.com
Cc: jing.lin@...el.com, ashok.raj@...el.com, sanjay.k.kumar@...el.com,
megha.dey@...el.com, jacob.jun.pan@...el.com, yi.l.liu@...el.com,
tglx@...utronix.de
Subject: [PATCH v2 2/2] dmaengine: idxd: Fix incorrect descriptions for GRPCFG register
From: Guanjun <guanjun@...ux.alibaba.com>
Fix incorrect descriptions for the GRPCFG register which has three
sub-registers (GRPWQCFG, GRPENGCFG and GRPFLGCFG).
No functional changes
Signed-off-by: Guanjun <guanjun@...ux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>
---
drivers/dma/idxd/registers.h | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/idxd/registers.h b/drivers/dma/idxd/registers.h
index 7b54a3939ea1..133bd0c170ae 100644
--- a/drivers/dma/idxd/registers.h
+++ b/drivers/dma/idxd/registers.h
@@ -440,12 +440,15 @@ union wqcfg {
/*
* This macro calculates the offset into the GRPCFG register
* idxd - struct idxd *
- * n - wq id
- * ofs - the index of the 32b dword for the config register
+ * n - group id
+ * ofs - the index of the 64b qword for the config register
*
- * The WQCFG register block is divided into groups per each wq. The n index
- * allows us to move to the register group that's for that particular wq.
- * Each register is 32bits. The ofs gives us the number of register to access.
+ * The GRPCFG register block is divided into three sub-registers, which
+ * are GRPWQCFG, GRPENGCFG and GRPFLGCFG. The n index in each group
+ * allows us to move to the register group that's for that contains the
+ * three sub-registers.
+ * Each register is 64bits. And the ofs in GRPWQCFG gives us the offset
+ * within the GRPCFG register to access.
*/
#define GRPWQCFG_OFFSET(idxd_dev, n, ofs) ((idxd_dev)->grpcfg_offset +\
(n) * GRPCFG_SIZE + sizeof(u64) * (ofs))
--
2.39.3
Powered by blists - more mailing lists