linux-kernel - Re: [PATCH 1/6] dt-bindings: mfd: brcm,bcm59056: Convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ae3d997-7a3e-487b-9d18-0101c3ba8e8e@linaro.org>
Date:   Tue, 31 Oct 2023 14:54:24 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Artur Weber <aweber.kernel@...il.com>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Stanislav Jakubek <stano.jakubek@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: mfd: brcm,bcm59056: Convert to YAML

On 31/10/2023 10:36, Artur Weber wrote:
> 
> 
> On 31.10.2023 06:52, Krzysztof Kozlowski wrote:
>> On 30/10/2023 20:36, Artur Weber wrote:
>>> Convert devicetree bindings for the Broadcom BCM59056 PMU MFD from
>>> TXT to YAML format. This patch does not change any functionality;
>>> the bindings remain the same.
>>> ...
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>
>> There is no other feature here, so this should go to regulators directory.
> 
> There are no other features *yet*, but the driver will eventually be 
> expanded to support the other features of the PMIC (charger, fuel gauge, 
> rtc, etc.).

The bindings should be complete regardless of driver support, but if
things are missing then it's okay. It can be in MFD.

> 
> In that case, should I move the bindings to regulators for now, and move 
> them back when the other features are added, or would it be fine to keep 
> it in mfd?
Best regards,
Krzysztof