linux-kernel - Re: [PATCH] x86: Let AS_WRUSS depend on X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80496187-8392-4c9e-ba05-89edea53e6e0@kernel.org>
Date:   Tue, 31 Oct 2023 14:59:39 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Borislav Petkov <bp@...en8.de>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     peterz@...radead.org, linux-kernel@...r.kernel.org,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Mike Rapoport <rppt@...nel.org>,
        Pengfei Xu <pengfei.xu@...el.com>,
        John Allen <john.allen@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] x86: Let AS_WRUSS depend on X86_64

On 31. 10. 23, 14:34, Borislav Petkov wrote:
> On Tue, Oct 31, 2023 at 09:20:33PM +0900, Masahiro Yamada wrote:
>> Please note "depends on X86_64" cannot prevent gcc
>> from running here.
>>
>> $(as-instr,wrussq %rax$(comma)(%rbx)) is replaced with 'y'
>> while parsing the Kconfig files.
>>
> Then what is this fixing?
> > Jiri, what openSUSE kernel build issues were you referring to on IRC?

As I wrote, we have a config which maintainers feed through oldconfig 
when updating the kernel. This time we got WRUSS=y. It was stored in git 
and later passed to build the kernel. And we received a different config 
from the build (WRUSS=n).

We diff the two and error out if the built kernel differs from the 
passed configuration. Which is the case here.

hth,
-- 
js