linux-kernel - Re: [PATCH] x86: Let AS_WRUSS depend on X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9f43a23-9202-41f3-b8fb-bf48f74e8a1e@kernel.org>
Date:   Tue, 31 Oct 2023 15:10:38 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Masahiro Yamada <masahiroy@...nel.org>, peterz@...radead.org,
        linux-kernel@...r.kernel.org, Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Mike Rapoport <rppt@...nel.org>,
        Pengfei Xu <pengfei.xu@...el.com>,
        John Allen <john.allen@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] x86: Let AS_WRUSS depend on X86_64

On 31. 10. 23, 15:05, Borislav Petkov wrote:
> On Tue, Oct 31, 2023 at 02:59:39PM +0100, Jiri Slaby wrote:
>> As I wrote, we have a config which maintainers feed through oldconfig when
>> updating the kernel. This time we got WRUSS=y. It was stored in git and
>> later passed to build the kernel. And we received a different config from
>> the build (WRUSS=n).
>>
>> We diff the two and error out if the built kernel differs from the passed
>> configuration. Which is the case here.
> 
> I sure hope that diffing script can ignore Kconfig items.

Definitely, I can add an ignore on that level.

> Because this
> doesn't sound like a reason to "fix" the upstream kernel and as Masahiro
> says, it doesn't change anything anyway.

It changes what's in .config and corresponds 1:1 to what is used during 
the build.

Now, I have a .config from "make oldconfig". But "make all" will read it 
and flips the value. (That is IMHO misleading, but I can live with that, 
provided I now know. Not sure about others though.)

thanks,
-- 
js
suse labs