linux-kernel - Re: [PATCH 4/5] wifi: brcmfmac: Support bss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18b868fffd0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date:   Tue, 31 Oct 2023 17:27:46 +0100
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Daniel Berlin <dberlin@...rlin.org>
CC:     Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        <linux-wireless@...r.kernel.org>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <SHA-cyfmac-dev-list@...ineon.com>, <linux-kernel@...r.kernel.org>,
        Hector Martin <marcan@...can.st>
Subject: Re: [PATCH 4/5] wifi: brcmfmac: Support bss_info up to v112



On October 31, 2023 3:04:12 PM Daniel Berlin <dberlin@...rlin.org> wrote:

> On Fri, Oct 20, 2023 at 1:31 PM Daniel Berlin <dberlin@...rlin.org> wrote:
>>
>> So, at least in the example code I have, all variants of the 109 and
>> 112 structures both have bcnflags in that place - it was always
>> missing here.
>> For example, see
>> https://android.googlesource.com/kernel/google-modules/wlan/bcmdhd/bcm4398/+/refs/heads/android-gs-shusky-5.15-u-qpr1-beta2/include/wlioctl.h
>> and  compare v109 and v112 of bssinfo.
>>
>> As such, the 109 and 112 structures are compatible given these definitions.
>>
>> I don't know if what is there right now is wrong, or it is "yet
>> another variant" of the 109 structure that we need to handle.
>> Any idea what the ground truth is?
>
> Circling back to this - i have checked other sources as well -
> infineon also has u8 (though it's marked as padding) there, etc.
>
> As far as i can tell, the structure should have that u8 there in all
> versions i can find.
>
> Nevertheless, I think I can make it not matter ;)
>
> I'm going to post an RFC of some patches that handle this and other
> structure versioning
> things through function pointer structures that we set based on
> interface versions available. So instead of setting feature flags, we
> query the various iovars/firmware
> info for the right interface versions, and set up the
> structures/function pointers to handle the versions
> we will get from the firmware

The feature flag approach was a concern and the above is more or less what 
I had in mind so curious to see how this takes shape.

Regards,
Arend



Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)