[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1e2acafb-fbc3-4256-b1e1-3fe6c47b1ef2@redhat.com>
Date: Tue, 31 Oct 2023 17:30:24 +0100
From: Danilo Krummrich <dakr@...hat.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>,
Thomas Hellström
<thomas.hellstrom@...ux.intel.com>, airlied@...il.com,
daniel@...ll.ch, matthew.brost@...el.com, sarah.walker@...tec.com,
donald.robson@...tec.com, boris.brezillon@...labora.com,
christian.koenig@....com, faith@...strand.net
Cc: nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH drm-misc-next v7 4/7] drm/gpuvm: add an abstraction for a
VM / BO combination
On 10/31/23 12:45, Jani Nikula wrote:
> On Tue, 31 Oct 2023, Thomas Hellström <thomas.hellstrom@...ux.intel.com> wrote:
>> On Mon, 2023-10-23 at 22:16 +0200, Danilo Krummrich wrote:
>>> + * Returns: a pointer to the &drm_gpuvm_bo on success, NULL on
>>
>> Still needs s/Returns:/Return:/g
>
> FWIW, both work to accommodate the variance across the kernel, although
> I think only the latter is documented and recommended. It's also the
> most popular:
>
> 10577 Return
> 3596 Returns
I'd like to keep "Returns", since that's what GPUVM uses already everywhere else.
> 1104 RETURN
> 568 return
> 367 returns
> 352 RETURNS
> 1 RETURNs
>
> BR,
> Jani.
>
>
Powered by blists - more mailing lists