linux-kernel - Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Nov 2023 08:35:20 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Raag Jadav <raag.jadav@...el.com>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength
 assignment to a switch-case

On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote:
> iWhen ->pin_config_set() is called from the GPIO library (assumed
> GpioIo() ACPI resource), the argument can be 1, when, for example,
> PullDefault is provided. In such case we supply sane default in
> the driver. Move that default assingment to a switch-case, so
> it will be consolidated in one place.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/pinctrl/intel/pinctrl-tangier.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
> index 007bca1cf224..26e34ec0a972 100644
> --- a/drivers/pinctrl/intel/pinctrl-tangier.c
> +++ b/drivers/pinctrl/intel/pinctrl-tangier.c
> @@ -368,14 +368,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
>  		break;
>  
>  	case PIN_CONFIG_BIAS_PULL_UP:
> -		/* Set default strength value in case none is given */
> -		if (arg == 1)
> -			arg = 20000;
> -
>  		switch (arg) {
>  		case 50000:
>  			term = BUFCFG_PUPD_VAL_50K;
>  			break;
> +		case 1: /* Set default strength value in case none is given */

The comment is good but I think would it make sense to have constant for
this instead?

>  		case 20000:
>  			term = BUFCFG_PUPD_VAL_20K;
>  			break;
> @@ -394,14 +391,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
>  		break;
>  
>  	case PIN_CONFIG_BIAS_PULL_DOWN:
> -		/* Set default strength value in case none is given */
> -		if (arg == 1)
> -			arg = 20000;
> -
>  		switch (arg) {
>  		case 50000:
>  			term = BUFCFG_PUPD_VAL_50K;
>  			break;
> +		case 1: /* Set default strength value in case none is given */
>  		case 20000:
>  			term = BUFCFG_PUPD_VAL_20K;
>  			break;
> -- 
> 2.40.0.1.gaa8946217a0b