linux-kernel - Re: mainline build failure due to 5cfd69775eb5 ("bcachefs: Array bounds fixes")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Nov 2023 08:24:28 +0100
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Kent Overstreet <kent.overstreet@...ux.dev>
Cc:     linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        regressions@...ts.linux.dev
Subject: Re: mainline build failure due to 5cfd69775eb5 ("bcachefs: Array
 bounds fixes")

On 01.11.23 06:18, Sudip Mukherjee wrote:
> On Tue, 31 Oct 2023 at 22:24, Kent Overstreet <kent.overstreet@...ux.dev> wrote:
>> On Tue, Oct 31, 2023 at 10:15:09PM +0000, Sudip Mukherjee (Codethink) wrote:
>>>
>>> The latest mainline kernel branch fails to build arm64 allmodconfig
>>> with a native build on an arm64 host with the error:
>>[...]
>> Following patch should resolve everything:
>[...]
> Thanks, and I can confirm that fixes the build for me too on the arm hosts.

>> -- >8 --
>> From ad77f25f730ec9a0eb04be5adc591628654b85ae Mon Sep 17 00:00:00 2001
>> From: Kent Overstreet <kent.overstreet@...ux.dev>
>> Date: Tue, 31 Oct 2023 18:05:22 -0400
>> Subject: [PATCH] bcachefs: Fix build errors with gcc 10
>>
>> gcc 10 seems to complain about array bounds in situations where gcc 11
>> does not - curious.
>>
>> This unfortunately requires adding some casts for now; we may
>> investigate getting rid of our __u64 _data[] VLA in a future patch so
>> that our start[0] members can be VLAs.
>>
>> Reported-by: John Stoffel <john@...ffel.org>
>> Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>
> 
> Tested-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Kent, thx for handling this so quickly. If you want to do me a favor,
please in the future include a "Link:" or "Closes:" tag with a URL to
the report in cases like this, as explained in the docs (it's important
for regression tracking, but also for future code archeologists);
checkpatch should have pointed this out for this patch.

Anyway, no big deal here, let me tell regzbot directly about the fix:

#regzbot fix: bcachefs: Fix build errors with gcc 10

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.