linux-kernel - Re: [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5799c6dd-e9ae-ce9f-b9a6-096d03916584@quicinc.com>
Date:   Wed, 1 Nov 2023 15:48:08 +0800
From:   Ziqi Chen <quic_ziqichen@...cinc.com>
To:     Manivannan Sadhasivam <mani@...nel.org>
CC:     <quic_asutoshd@...cinc.com>, <quic_cang@...cinc.com>,
        <bvanassche@....org>, <beanhuo@...ron.com>, <avri.altman@....com>,
        <junwoo80.lee@...sung.com>, <martin.petersen@...cle.com>,
        <quic_nguyenb@...cinc.com>, <quic_nitirawa@...cinc.com>,
        <quic_rampraka@...cinc.com>, <linux-scsi@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ



On 11/1/2023 1:01 PM, Manivannan Sadhasivam wrote:
> On Wed, Nov 01, 2023 at 12:01:09PM +0800, Ziqi Chen wrote:
>> The Message Signaled Interrupt (MSI) has been used
>> by UFS driver since the MCQ be enabled. Hence in UFS
>> DT node, we need to give the msi-parent property that
>> point to the hardware entity that serves as the MSI
>> controller for this UFS controller.
>>
>> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
>> ---
>>   Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index 462ead5..d2f505a 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -103,6 +103,8 @@ properties:
>>       description:
>>         GPIO connected to the RESET pin of the UFS memory device.
>>   
>> +  msi-parent: true
>> +
> 
> This property is not Qcom specific. So this should be part of ufs-common.yaml.
Make sense, thanks for review, I will update to ufs-common.yam.
> 
> - Mani
> 
>>   required:
>>     - compatible
>>     - reg
>> @@ -318,5 +320,6 @@ examples:
>>                               <0 0>,
>>                               <0 0>;
>>               qcom,ice = <&ice>;
>> +            msi-parent = <&gic_its 0x60>;
>>           };
>>       };
>> -- 
>> 2.7.4
>>
>