linux-kernel - Re: [PATCH 1/1] Revert "media: imx290: Convert to new CCI register access helpers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUIpEJmmdGTFdx09@kekkonen.localdomain>
Date:   Wed, 1 Nov 2023 10:31:44 +0000
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Alexander Stein <alexander.stein@...tq-group.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Revert "media: imx290: Convert to new CCI register
 access helpers"

Hi Alexander,

On Wed, Nov 01, 2023 at 11:09:00AM +0100, Alexander Stein wrote:
> cci_write() unconditionally writes multi-byte data in big-endian format.
> But IMX290 and IMX327 use little-endian format for multi-byte registers.
> Revert the CCI usage until little-endian is supported by CCI register
> access helpers.
> This reverts commit af73323b97702e53b0a336972aaf23e7dd92c850.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> The difference is subtile, but imx290_write() uses put_unaligned_le24(),
> while cci_write() uses put_unaligned_be24().
> 
> I assume this should go into stable as well. How to deal with that?
> Shall a revert get the fixes tag as well?

I'd very much prefer addressing this in v4l2-cci instead. It should also be
a much smaller patch (or patches).

-- 
Regards,

Sakari Ailus