linux-kernel - Re: [PATCH v2 1/2] leds: core: add missing LED color strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZUI4E06PYez5Z5LI@xhacker>
Date:   Wed, 1 Nov 2023 19:35:47 +0800
From:   Jisheng Zhang <jszhang@...nel.org>
To:     Shiji Yang <yangshiji66@...look.com>
Cc:     devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Olliver Schinagl <oliver@...inagl.nl>
Subject: Re: [PATCH v2 1/2] leds: core: add missing LED color strings

On Tue, Oct 31, 2023 at 09:29:00PM +0800, Shiji Yang wrote:
> Some new monochromatic LEDs have been introduced into DT bindings,
> but they do not have corresponding descriptions on the led_colors
> structure. This patch adds the missing LED color strings.
> 
> Fixes: 472d7b9e8141 ("dt-bindings: leds: Expand LED_COLOR_ID definitions")
> Signed-off-by: Shiji Yang <yangshiji66@...look.com>
> ---
>  drivers/leds/led-core.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> index 214ed81eb..223023928 100644
> --- a/drivers/leds/led-core.c
> +++ b/drivers/leds/led-core.c
> @@ -36,6 +36,11 @@ const char * const led_colors[LED_COLOR_ID_MAX] = {
>  	[LED_COLOR_ID_IR] = "ir",
>  	[LED_COLOR_ID_MULTI] = "multicolor",
>  	[LED_COLOR_ID_RGB] = "rgb",
> +	[LED_COLOR_ID_PURPLE] = "purple",
> +	[LED_COLOR_ID_ORANGE] = "orange",
> +	[LED_COLOR_ID_PINK] = "pink",
> +	[LED_COLOR_ID_CYAN] = "cyan",
> +	[LED_COLOR_ID_LIME] = "lime",

A similar patch was sent out two days ago, earlier than yours ;)

https://lore.kernel.org/linux-leds/20231030054757.3476-1-jszhang@kernel.org/

>  };
>  EXPORT_SYMBOL_GPL(led_colors);
>  
> -- 
> 2.39.2
>