linux-kernel - Re: [RFC PATCH v4 3/9] slub: Keep track of whether slub is on the per-node partial list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0273835d-5aac-f8b5-7675-7c7aeca3cb4d@suse.cz>
Date:   Wed, 1 Nov 2023 13:23:27 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     chengming.zhou@...ux.dev, cl@...ux.com, penberg@...nel.org,
        willy@...radead.org
Cc:     rientjes@...gle.com, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, roman.gushchin@...ux.dev,
        42.hyeyoo@...il.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Chengming Zhou <zhouchengming@...edance.com>
Subject: Re: [RFC PATCH v4 3/9] slub: Keep track of whether slub is on the
 per-node partial list



On 10/31/23 15:07, chengming.zhou@...ux.dev wrote:
> From: Chengming Zhou <zhouchengming@...edance.com>
> 
> Now we rely on the "frozen" bit to see if we should manipulate the
> slab->slab_list, which will be changed in the following patch.
> 
> Instead we introduce another way to keep track of whether slub is on
> the per-node partial list, here we reuse the PG_workingset bit.
> 
> We use __set_bit and __clear_bit directly instead of the atomic version
> for better performance and it's safe since it's protected by the slub
> node list_lock.
> 
> Suggested-by: Matthew Wilcox <willy@...radead.org>
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>