linux-kernel - Re: [PATCH v1] hwmon: emc1403: Add support for EMC1442

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZUJkLJEpwji6czHJ@heinlein.vulture-banana.ts.net>
Date:   Wed, 1 Nov 2023 09:43:56 -0500
From:   Patrick Williams <patrick@...cx.xyz>
To:     Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Krish Skandakumaran <krishskanda@...a.com>,
        Jean Delvare <jdelvare@...e.com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] hwmon: emc1403: Add support for EMC1442

On Wed, Nov 01, 2023 at 08:45:15AM +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> > >>> ---
> > >>>     { "emc1422", emc1402 },
> > >>>     { "emc1423", emc1403 },
> > >>>     { "emc1424", emc1404 },
> > >>> +   { "emc1442", emc1403 },
> > >
> > > So, emc1402?
> > >
> > 
> > At the very least, if you are willing to confirm that formally if/when v2 is
> > submitted.
> > 
> > I previously rejected a similar patch adding emc1444 because it was impossible
> > to get a datasheet to confirm that the chips are really register compatible. No
> > idea why that has to be so secretive. It is a temperature sensor, for heaven's
> > sake :-(
> > 
> > Guenter
> 
> Hi Krish,
> Would need your confirmation of the device on the NIC.

I don't think we need additional feedback from Krish.  Please change to
emc1402 from emc1403.

The datasheet for EMC1442 even has a section titled "Functional Delta
from EMC1412 to EMC1442", which is effectively all non-software related.
Therefore, the compatibility here should match what was done for
"emc1412" which was `emc1402`.

I will send my Reviewed-by with a v2 using emc1402.

-- 
Patrick Williams

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)