linux-kernel - [RFC PATCH] iio: accel: st_accel: silent spi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231101151612.4159362-1-sean@geanix.com>
Date:   Wed,  1 Nov 2023 16:16:12 +0100
From:   Sean Nyekjaer <sean@...nix.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Cc:     Sean Nyekjaer <sean@...nix.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [RFC PATCH] iio: accel: st_accel: silent spi_device_id warnings

Add and correct spi_device_id entries to silent following warnings:
 SPI driver st-accel-spi has no spi_device_id for st,lis302dl-spi
 SPI driver st-accel-spi has no spi_device_id for st,lis3lv02dl-accel
 SPI driver st-accel-spi has no spi_device_id for st,lis3dh-accel
 SPI driver st-accel-spi has no spi_device_id for st,lsm330d-accel
 SPI driver st-accel-spi has no spi_device_id for st,lsm330dl-accel
 SPI driver st-accel-spi has no spi_device_id for st,lsm330dlc-accel
 SPI driver st-accel-spi has no spi_device_id for st,lis331dlh-accel
 SPI driver st-accel-spi has no spi_device_id for st,lsm330-accel
 SPI driver st-accel-spi has no spi_device_id for st,lsm303agr-accel
 SPI driver st-accel-spi has no spi_device_id for st,lis2dh12-accel
 SPI driver st-accel-spi has no spi_device_id for st,lng2dm-accel
 SPI driver st-accel-spi has no spi_device_id for st,h3lis331dl-accel
 SPI driver st-accel-spi has no spi_device_id for st,lis331dl-accel
 SPI driver st-accel-spi has no spi_device_id for st,lsm303c-accel

Signed-off-by: Sean Nyekjaer <sean@...nix.com>
---
Is the names with underscore from ACPI or?
Is it fine to do this?

 drivers/iio/accel/st_accel.h     | 35 ++++++++++++++++----------------
 drivers/iio/accel/st_accel_spi.c |  1 +
 2 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
index e7525615712b..817ccd0423d5 100644
--- a/drivers/iio/accel/st_accel.h
+++ b/drivers/iio/accel/st_accel.h
@@ -14,30 +14,31 @@
 #include <linux/types.h>
 #include <linux/iio/common/st_sensors.h>
 
-#define H3LIS331DL_ACCEL_DEV_NAME	"h3lis331dl_accel"
-#define LIS3LV02DL_ACCEL_DEV_NAME	"lis3lv02dl_accel"
-#define LSM303DLHC_ACCEL_DEV_NAME	"lsm303dlhc_accel"
-#define LIS3DH_ACCEL_DEV_NAME		"lis3dh"
-#define LSM330D_ACCEL_DEV_NAME		"lsm330d_accel"
-#define LSM330DL_ACCEL_DEV_NAME		"lsm330dl_accel"
-#define LSM330DLC_ACCEL_DEV_NAME	"lsm330dlc_accel"
-#define LIS331DL_ACCEL_DEV_NAME		"lis331dl_accel"
-#define LIS331DLH_ACCEL_DEV_NAME	"lis331dlh"
-#define LSM303DL_ACCEL_DEV_NAME		"lsm303dl_accel"
-#define LSM303DLH_ACCEL_DEV_NAME	"lsm303dlh_accel"
-#define LSM303DLM_ACCEL_DEV_NAME	"lsm303dlm_accel"
-#define LSM330_ACCEL_DEV_NAME		"lsm330_accel"
-#define LSM303AGR_ACCEL_DEV_NAME	"lsm303agr_accel"
-#define LIS2DH12_ACCEL_DEV_NAME		"lis2dh12_accel"
+#define H3LIS331DL_ACCEL_DEV_NAME	"h3lis331dl-accel"
+#define LIS3LV02DL_ACCEL_DEV_NAME	"lis3lv02dl-accel"
+#define LSM303DLHC_ACCEL_DEV_NAME	"lsm303dlhc-accel"
+#define LIS3DH_ACCEL_DEV_NAME		"lis3dh-accel"
+#define LSM330D_ACCEL_DEV_NAME		"lsm330d-accel"
+#define LSM330DL_ACCEL_DEV_NAME		"lsm330dl-accel"
+#define LSM330DLC_ACCEL_DEV_NAME	"lsm330dlc-accel"
+#define LIS331DL_ACCEL_DEV_NAME		"lis331dl-accel"
+#define LIS331DLH_ACCEL_DEV_NAME	"lis331dlh-accel"
+#define LSM303DL_ACCEL_DEV_NAME		"lsm303dl-accel"
+#define LSM303DLH_ACCEL_DEV_NAME	"lsm303dlh-accel"
+#define LSM303DLM_ACCEL_DEV_NAME	"lsm303dlm-accel"
+#define LSM330_ACCEL_DEV_NAME		"lsm330-accel"
+#define LSM303AGR_ACCEL_DEV_NAME	"lsm303agr-accel"
+#define LIS2DH12_ACCEL_DEV_NAME		"lis2dh12-accel"
 #define LIS3L02DQ_ACCEL_DEV_NAME	"lis3l02dq"
-#define LNG2DM_ACCEL_DEV_NAME		"lng2dm"
+#define LNG2DM_ACCEL_DEV_NAME		"lng2dm-accel"
 #define LIS2DW12_ACCEL_DEV_NAME		"lis2dw12"
 #define LIS3DHH_ACCEL_DEV_NAME		"lis3dhh"
 #define LIS3DE_ACCEL_DEV_NAME		"lis3de"
 #define LIS2DE12_ACCEL_DEV_NAME		"lis2de12"
 #define LIS2HH12_ACCEL_DEV_NAME		"lis2hh12"
 #define LIS302DL_ACCEL_DEV_NAME		"lis302dl"
-#define LSM303C_ACCEL_DEV_NAME		"lsm303c_accel"
+#define LIS302DL_SPI_ACCEL_DEV_NAME	"lis302dl-spi"
+#define LSM303C_ACCEL_DEV_NAME		"lsm303c-accel"
 #define SC7A20_ACCEL_DEV_NAME		"sc7a20"
 #define IIS328DQ_ACCEL_DEV_NAME		"iis328dq"
 
diff --git a/drivers/iio/accel/st_accel_spi.c b/drivers/iio/accel/st_accel_spi.c
index f72a24f45322..749d770d2350 100644
--- a/drivers/iio/accel/st_accel_spi.c
+++ b/drivers/iio/accel/st_accel_spi.c
@@ -160,6 +160,7 @@ static const struct spi_device_id st_accel_id_table[] = {
 	{ LIS3DHH_ACCEL_DEV_NAME },
 	{ LIS3DE_ACCEL_DEV_NAME },
 	{ LIS302DL_ACCEL_DEV_NAME },
+	{ LIS302DL_SPI_ACCEL_DEV_NAME },
 	{ LSM303C_ACCEL_DEV_NAME },
 	{ IIS328DQ_ACCEL_DEV_NAME },
 	{},
-- 
2.42.0