linux-kernel - Re: [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Nov 2023 15:33:30 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Vincent Knecht <vincent.knecht@...loo.org>
Cc:     Tianshu Qiu <tian.shu.qiu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Yassine Oudjana <y.oudjana@...tonmail.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support

On Wed, Nov 01, 2023 at 04:29:20PM +0100, Vincent Knecht wrote:
> Le mercredi 01 novembre 2023 à 15:10 +0000, Conor Dooley a écrit :
> > On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote:
> > > Document AK7345 bindings.
> > 
> > The commit message should mention why this device is incompatible with
> > the 7375. Something like
> > 
> > "Document the ak7345 voice coil motor actuator. Similar to the ak7375,
> > this model has 4 unilateral phase detractors instead of 8."
> > 
> > Otherwise,
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> > 
> > Cheers,
> > Conor.
> 
> Thank you for the review!
> 
> I don't know anything about phase detractors, nor any other details

hah, that was just me putting techobabble in the example text rather
than using foo. See also:
https://www.youtube.com/watch?v=RXJKdh1KZ0w

> (having found no datasheets for either of these ICs)
> apart what could be infered from vendor/downstream drivers
> like in the commit text for patch 3/3...
> 
> So I guess I'll send a v2 with a commit text along these lines :
> Document AK7345 bindings.
> Compared to AK7375, it has only 9 bits position values (instead of 12),
> 20 ms power-up delay (instead of 10), and no known standby register setting.

Yah, that is the exact sort of information that is good to have, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)