linux-kernel - Re: [PATCH] jfs: fix uaf in jfs_evict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e3c0e7aa-2ee5-4958-99c5-74c25c3869e4@oracle.com>
Date:   Wed, 1 Nov 2023 10:48:25 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Edward Adam Davis <eadavis@...com>,
        syzbot+01cf2dbcbe2022454388@...kaller.appspotmail.com
Cc:     jfs-discussion@...ts.sourceforge.net,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] jfs: fix uaf in jfs_evict_inode

On 10/31/23 12:39AM, Edward Adam Davis wrote:
> When the execution of diMount(ipimap) fails, the object ipimap that has been
> released may be accessed in diFreeSpecial(). Asynchronous ipimap release occurs
> when rcu_core() calls jfs_free_node().
> 
> Therefore, when diMount(ipimap) fails, sbi->ipimap should not be initialized as
> ipimap.
> 
> Reported-and-tested-by: syzbot+01cf2dbcbe2022454388@...kaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@...com>

Looks good.

Thanks,
Shaggy

> ---
>   fs/jfs/jfs_mount.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/jfs/jfs_mount.c b/fs/jfs/jfs_mount.c
> index 415eb65a36ff..9b5c6a20b30c 100644
> --- a/fs/jfs/jfs_mount.c
> +++ b/fs/jfs/jfs_mount.c
> @@ -172,15 +172,15 @@ int jfs_mount(struct super_block *sb)
>   	}
>   	jfs_info("jfs_mount: ipimap:0x%p", ipimap);
>   
> -	/* map further access of per fileset inodes by the fileset inode */
> -	sbi->ipimap = ipimap;
> -
>   	/* initialize fileset inode allocation map */
>   	if ((rc = diMount(ipimap))) {
>   		jfs_err("jfs_mount: diMount failed w/rc = %d", rc);
>   		goto err_ipimap;
>   	}
>   
> +	/* map further access of per fileset inodes by the fileset inode */
> +	sbi->ipimap = ipimap;
> +
>   	return rc;
>   
>   	/*