linux-kernel - Re: [PATCH v2 2/2] dt-bindings: leds: add "internet" and "rssi" function definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  1 Nov 2023 09:47:31 +0800
From:   Shiji Yang <yangshiji66@...look.com>
To:     robh@...nel.org
Cc:     conor+dt@...nel.org, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        oliver@...inagl.nl, pavel@....cz
Subject: Re: [PATCH v2 2/2] dt-bindings: leds: add "internet" and "rssi" function definitions

On Tue, 31 Oct 2023 13:03:05 -0500, Rob Herring wrote:

>On Tue, Oct 31, 2023 at 09:29:01PM +0800, Shiji Yang wrote:
>> These two types of LEDs are widely used in routers and NICs. The
>> RSSI (Received Signal Strength Indicator) LED is used to display
>> the Wi-Fi signal strength, and the Internet LED can indicate
>> whether the device can access a specific server.
>> 
>> Signed-off-by: Shiji Yang <yangshiji66@...look.com>
>> ---
>>  include/dt-bindings/leds/common.h | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
>> index 9a0d33d02..55a426e39 100644
>> --- a/include/dt-bindings/leds/common.h
>> +++ b/include/dt-bindings/leds/common.h
>> @@ -88,11 +88,13 @@
>>  #define LED_FUNCTION_FLASH "flash"
>>  #define LED_FUNCTION_HEARTBEAT "heartbeat"
>>  #define LED_FUNCTION_INDICATOR "indicator"
>> +#define LED_FUNCTION_INTERNET "internet"
>
>Duplicate of 'wan'.

It's different from 'wan'. 'wan' usually indicates whether the WAN
port is connected to the modem (internet services may still
unavailable). But the 'internet' shows if the device can successfully
ping servers like 8.8.8.8 to detected the internet connection status.
When the router operates in AP only mode, we can even connect LAN port
to the AC/modem to connect to the internet. In this case, 'internet'
LED should still be on. On some routers, both 'internet' and 'wan'
are available and be controled separately.

Ref: OpenWrt has a lot of devices that require the 'internet' LED：
https://git.openwrt.org/?p=openwrt%2Fopenwrt.git&a=search&h=HEAD&st=grep&s=label+%3D+.*net&sr=1

Anyway, if it is still unacceptable, please let me know and I will
remove it in v3.

>
>>  #define LED_FUNCTION_LAN "lan"
>>  #define LED_FUNCTION_MAIL "mail"
>>  #define LED_FUNCTION_MTD "mtd"
>>  #define LED_FUNCTION_PANIC "panic"
>>  #define LED_FUNCTION_PROGRAMMING "programming"
>> +#define LED_FUNCTION_RSSI "rssi"
>
>'rx' or 'wlan'?

'rx' and 'wlan' only shows the data transfer speed and on/off status, this
one indicates the signal strength.

>
>Wouldn't you need multiple LEDs to indicate signal strength? Maybe 
>'signal' or something would be more generic?

Yes, usually there are 3~4 LEDs to indicate the signal strength, just like
the signal icon on the mobile phone. We can use `function-enumerator` led
property to mark the different leds in the signal group. I'll rename it to
'signal' in v3.

>
>>  #define LED_FUNCTION_RX "rx"
>>  #define LED_FUNCTION_SD "sd"
>>  #define LED_FUNCTION_STANDBY "standby"
>> -- 
>> 2.39.2
>> 

Regards,
Shiji Yang