linux-kernel - Re: [PATCH] regmap: prevent noinc writes from clobbering cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0e8c9f5-7aff-4adc-b5bc-d61c6107c07f@sirena.org.uk>
Date:   Wed, 1 Nov 2023 17:05:39 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Ben Wolsieffer <ben.wolsieffer@...ring.com>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Ben Whitten <ben.whitten@...il.com>
Subject: Re: [PATCH] regmap: prevent noinc writes from clobbering cache

On Wed, Nov 01, 2023 at 10:29:27AM -0400, Ben Wolsieffer wrote:
> Currently, noinc writes are cached as if they were standard incrementing
> writes, overwriting unrelated register values in the cache. Instead, we
> want to cache the last value written to the register, as is done in the
> accelerated noinc handler (regmap_noinc_readwrite).

Could you please add a kunit test for this?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)